fix: Add enum types for commerce event #498
Conversation
|
|
||
| Unknown(0), Navigation(1), Location(2), Search(3), Transaction(4), UserContent(5), UserPreference(6), |
There was a problem hiding this comment.
this would be an incorrect public api change that'd likely cause a lot of pain and bugs :-) please revert
this enum is the one for custom events. it isn't meant to be used for all event types. ios does it this way and it's been a bug and complaint for years - customers for example log regular custom events with incorrect event types.
create some other private enum if we need it internally? these enum values shouldn't be exposed to customers.
| MPEvent.Builder itemEvent; | ||
| switch (productAction) { | ||
| case Product.ADD_TO_CART: | ||
| itemEvent = new MPEvent.Builder(String.format(ITEM_NAME, productAction), MParticle.EventType.AddToCart); |
There was a problem hiding this comment.
and this is exactly what customers do and is not correct. then we end up with weird data, broken filtering, integrations, etc.
MPEvent is custom event and cannot have AddToCart (or any of the others below) as a custom event type in our schema.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)